[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitializ

From: Andreas Färber
Subject: [Qemu-devel] [PATCH for-1.6] virtio-9p-device: Avoid freeing uninitialized memory
Date: Thu, 1 Aug 2013 01:59:47 +0200

In virtio_9p_device_init() there are 6x goto out that will lead to
v9fs_path_free() attempting to free unitialized path.data field.
Easiest way to trigger is: qemu-system-x86_64 -device virtio-9p-pci

Fix this by moving v9fs_path_init() before any goto out.

Signed-off-by: Andreas Färber <address@hidden>
 hw/9pfs/virtio-9p-device.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c
index de6f0fe..f0ffbe8 100644
--- a/hw/9pfs/virtio-9p-device.c
+++ b/hw/9pfs/virtio-9p-device.c
@@ -61,6 +61,8 @@ static int virtio_9p_device_init(VirtIODevice *vdev)
     s->vq = virtio_add_queue(vdev, MAX_REQ, handle_9p_output);
+    v9fs_path_init(&path);
     fse = get_fsdev_fsentry(s->fsconf.fsdev_id);
     if (!fse) {
@@ -111,7 +113,6 @@ static int virtio_9p_device_init(VirtIODevice *vdev)
      * call back to do that. Since we are in the init path, we don't
      * use co-routines here.
-    v9fs_path_init(&path);
     if (s->ops->name_to_path(&s->ctx, NULL, "/", &path) < 0) {
                 "error in converting name to path %s", strerror(errno));

reply via email to

[Prev in Thread] Current Thread [Next in Thread]