Re: [Qemu-devel] [PATCH V7 01/11] NUMA: add NumaOptions, NumaNodeOptions and NumaMemOptions

[Laszlo Ersek]

On 07/31/13 08:42, Wanlong Gao wrote:
> Signed-off-by: Wanlong Gao <address@hidden>
> ---
>  qapi-schema.json | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 47 insertions(+)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index a51f7d2..b9b18e4 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3773,3 +3773,50 @@
>  ##
>  { 'command': 'query-rx-filter', 'data': { '*name': 'str' },
>    'returns': ['RxFilterInfo'] }
> +
> +##
> +# @NumaOptions
> +#
> +# A discriminated record of NUMA options.
> +#
> +# Since 1.7
> +##
> +{ 'union': 'NumaOptions',
> +  'data': {
> +    'node': 'NumaNodeOptions',
> +    'mem':  'NumaMemOptions' }}
> +
> +##
> +# @NumaNodeOptions
> +#
> +# Create a guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @cpus: #optional VCPUs belong to this node
> +#
> +# @mem: #optional memory size of this node (remain as legacy)
> +#
> +# Since: 1.7
> +##
> +{ 'type': 'NumaNodeOptions',
> +  'data': {
> +   '*nodeid': 'uint16',
> +   '*cpus':   ['uint16'],
> +   '*mem':    'str' }}
> +
> +##
> +# @NumaMemOptions
> +#
> +# Set memory information of guest NUMA node.
> +#
> +# @nodeid: #optional NUMA node ID
> +#
> +# @size: #optional memory size of this node
> +#
> +# Since 1.7
> +##
> +{ 'type': 'NumaMemOptions',
> +  'data': {
> +   '*nodeid': 'uint16',
> +   '*size':   'size' }}
> 

Reviewed-by: Laszlo Ersek <address@hidden>

(and you already have it on V7 02/11, good)

Thanks
Laszlo