[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status im
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols |
|
Date: |
Wed, 31 Jul 2013 11:12:27 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben:
> Protocols return raw data, so you can assume the offsets to pass
> through unchanged.
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
Not really objecting, but is this useful?
In formats, BDRV_BLOCK_OFFSET_VALID means that the given offset is valid
for bs->file, which is something that protocols simply don't have. You
can do it like you do here, but actually this information is redundant.
Do you make use of it for anything?
Kevin
- Re: [Qemu-devel] [PATCH v3 13/19] qemu-img: add a "map" subcommand, (continued)
[Qemu-devel] [PATCH v3 14/19] docs, qapi: document qemu-img map, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 15/19] block: use bdrv_has_zero_init to return BDRV_BLOCK_ZERO, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 16/19] raw-posix: return get_block_status data and flags, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 17/19] raw-posix: detect XFS unwritten extents, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols, Paolo Bonzini, 2013/07/25
- Re: [Qemu-devel] [PATCH v3 18/19] block: add default get_block_status implementation for protocols,
Kevin Wolf <=
[Qemu-devel] [PATCH v3 19/19] block: look for zero blocks in bs->file, Paolo Bonzini, 2013/07/25