[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated stati
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static |
|
Date: |
Mon, 29 Jul 2013 15:21:29 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.07.2013 um 16:23 hat Paolo Bonzini geschrieben:
> bdrv_is_allocated can detect coroutine context and go through a fast
> path, similar to other block layer functions.
>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
It can, but why is this a good idea?
The other block layer functions do this because existing drivers call
bdrv_(p)read/write(v) and we don't want them to block the vcpu. So it's
basically just a method of avoiding massive changes to existing callers.
The only such caller of bdrv_is_allocated() that I can see is vvfat, and
I don't think optimising that is our top priority.
Charlie is working in exactly the opposite direction, namely splitting
the existing functions in a coroutine-only and a synchronous-only part.
We should be clear what we really want here.
Kevin
- [Qemu-devel] [PATCH v3 01/19] cow: make reads go at a decent speed, (continued)
[Qemu-devel] [PATCH v3 03/19] cow: do not call bdrv_co_is_allocated, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static, Paolo Bonzini, 2013/07/25
- Re: [Qemu-devel] [PATCH v3 05/19] block: make bdrv_co_is_allocated static,
Kevin Wolf <=
[Qemu-devel] [PATCH v3 06/19] block: remove bdrv_is_allocated_above/bdrv_co_is_allocated_above distinction, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 07/19] block: expect errors from bdrv_co_is_allocated, Paolo Bonzini, 2013/07/25
[Qemu-devel] [PATCH v3 09/19] block: make bdrv_has_zero_init return false for copy-on-write-images, Paolo Bonzini, 2013/07/25