[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] vhost acceleration broken?
From: |
Rusty Russell |
Subject: |
Re: [Qemu-devel] vhost acceleration broken? |
Date: |
Mon, 29 Jul 2013 09:25:20 +0930 |
User-agent: |
Notmuch/0.15.2+81~gd2c8818 (http://notmuchmail.org) Emacs/23.4.1 (i686-pc-linux-gnu) |
Anthony Liguori <address@hidden> writes:
> "Michael S. Tsirkin" <address@hidden> writes:
>
>> On Thu, Jul 25, 2013 at 04:56:05PM +0200, Andreas Färber wrote:
>>> Am 25.07.2013 16:52, schrieb Michael S. Tsirkin:
>>> > On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote:
>>> >> We have a pretty awful legacy command line set that comes from years of
>>> >> half-baked concepts and the years when too many people just committed
>>> >> random shit to the tree.
>>> >>
>>> >> I think we probably need to start planning for a clean break. Maybe
>>> >> that's a good target for a 2.0 version...
>>> >
>>> > Assuming -netdev supports all required configurations, we should
>>> > remove -net from the -help output.
>>>
>>> Peter had raised the issue of -netdev not working well with boards that
>>> already supply a default NIC - was there a solution yet?
>>>
>>> Andreas
>>
>> Whoever is removing -net will have to code that up. Want to do this?
>
> I would not rush to remove things. If we're going to go through a
> deprecation process, we should start with a proposal on what things
> should be removed and go from there.
>
> I still don't even think -netdev is the right answer here either.
> Wouldn't it make more sense to have something like:
>
> qemu -vnic tap,script=/foo/myscript
>
> Or something vaguely understandable by a human?
OK. It seems to me that each net device has a host side and a guest
side, which you can mix and match. So the commandline should reflect
that explicitly:
qemu -hostdev net,[tap|user|bridge|socket|vde],.... -guestdev net,....
If you have a built-in net device on your emulated board, you've got one
implied -guestdev net. And similar principles apply to other things
like consoles and disks.
Now, guest and host terms may suck. But please pick one terminology and
use it *everywhere*. Documentation, code and cmdline.
Thanks,
Rusty.
- [Qemu-devel] vhost acceleration broken?, Rusty Russell, 2013/07/24
- Re: [Qemu-devel] vhost acceleration broken?, Anthony Liguori, 2013/07/24
- Re: [Qemu-devel] vhost acceleration broken?, Rusty Russell, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Anthony Liguori, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Andreas Färber, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Anthony Liguori, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Peter Maydell, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/25
- Re: [Qemu-devel] vhost acceleration broken?,
Rusty Russell <=
- Re: [Qemu-devel] vhost acceleration broken?, Anthony Liguori, 2013/07/28
- Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/29
- Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/29
Re: [Qemu-devel] vhost acceleration broken?, Peter Maydell, 2013/07/25
Re: [Qemu-devel] vhost acceleration broken?, Michael S. Tsirkin, 2013/07/25