Re: [Qemu-devel] [PATCH RFC for-1.6 qom-next 0/3] PCIe VMState cleanups for 1.6

[Michael S. Tsirkin]

On Sun, Jul 28, 2013 at 03:41:07AM +0200, Andreas Färber wrote:
> Hello Michael and Gerd,
> 
> As discussed, this series attempts to clean up PCIe devices fiddling with
> individual PCIe VMState fields. It is based on my qom-next queue, containing
> type and field changes for PCIe devices.
> 
> Patch 1 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>    - Field X
>      ...
> b) - Struct A
>      - Field Aa
>      ...
>      - Field X
> 
> Patch 2 relies on XHCI not being released yet, thus no compatibiliy concerns.
> 
> Patch 3 assumes the following are equivalent:
> a) - Struct A
>      - Field Aa
>      ...
>      - Field X
> b) - Struct A
>      - Field Aa
>      ...
>      - Subsection Ax
>        - Field X
> 
> CC'ing Juan to verify which of these are correct/safe.
> 
> Regards,
> Andreas

As far as I know 2a and 2b are not equivalent: subsections
are serialized in the file.
You really should test by migrating to file (e.g. before
starting the guest) and checking.
Also, migrate to file from before patch and load after patch.