[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] musicpal: Fix typo in name of local function |
Date: |
Sun, 28 Jul 2013 13:10:23 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130623 Thunderbird/17.0.7 |
Am 28.07.2013 11:46, schrieb Andreas Färber:
> Am 28.07.2013 07:54, schrieb Stefan Weil:
>> The misspelling was spotted by Andreas Färber.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>> hw/arm/musicpal.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
[...]
>> Reviewed-by: Andreas Färber <address@hidden>
>>
>> but to clarify: I had notified you not to send this small patch, which
>> now conflicts with my argument cleanup, but to add this typo to your
>> blacklist to check the whole codebase for similar typos. Are there none?
>>
>> But since this is a sensible cleanup anyway, I'll just put a copy into
>> my queue before the refactoring, to avoid merge conflicts with -trivial.
>>
>> Thanks,
>> Andreas
Codespell uses a list of common misspellings which is an enhanced versionof
https://en.wikipedia.org/wiki/Wikipedia:Lists_of_common_misspellings/For_machines.
"Brigthness" was not among those words. Even if it were, codespell would not
detect it in a composed word like musicpal_lcd_gpio_brigthness_in.
With some small modifications (split words at [-_]), codespell detects more
misspellings in QEMU: bandwith, issueing, propietary, threshhold.
Even more could be detected by analysing composed words.
Regards,
Stefan