[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttlin

From: Benoît Canet
Subject: Re: [Qemu-devel] [PATCH V3 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the command line.
Date: Fri, 26 Jul 2013 22:55:25 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

> Kevin's series renamed these to have a dash in the name, and also moved
> all the throttling parameters into a sub-struct.  Does it make more
> sense to have just '*throttling' with that sub-struct containing 12
> parameters, 6 for limits and 6 for thresholds, or would it be better to
> have '*throttling' with 6 members for limits, as well as
> '*throttling-threshold' with the other 6 members?  Naming-wise,
> throttling.bps-total and throttling-threshold.bps-total convey as much
> information as throttling.bps-total and throttling.bps-total-threshold.

In fact my series add up to 13 parameters.
The last one is iops_sector_count so maybe I'll go the big sub-struct way.

Best regards


reply via email to

[Prev in Thread] Current Thread [Next in Thread]