[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v3 14/14] i386: ACPI table generation code from seabios
Date: Fri, 26 Jul 2013 17:30:29 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7


>> That's something I think that it's best for firmware to avoid.
>> Much better to load tables in memory and use standard ACPI
>> methods to find specific tables.
> Problem is this happens relatively late in the firmware boot process.

Completely different idea to tackle the issue: use COMMAND_ADD_POINTER
not only for table pointers, but also register offsets.  So the firmware
doesn't need to parse fadt to figure how it should program pm_base, but
instead can fixup the fadt according to the pm_base it has used.

That is more in line with how firmware works (pm_base and simliar things
tends to be #defines and are not runtime-configurable).  And I think
it's also more robust when extending/changing tables for newer acpi spec


reply via email to

[Prev in Thread] Current Thread [Next in Thread]