qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] [RFC 6/7] aio / timers: Switch to ppoll, run


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCHv2] [RFC 6/7] aio / timers: Switch to ppoll, run AioContext timers in aio_poll/aio_dispatch
Date: Fri, 26 Jul 2013 10:34:25 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Jul 25, 2013 at 03:53:55PM +0100, Alex Bligh wrote:
> Stefan,
> 
> --On 25 July 2013 11:33:43 +0200 Stefan Hajnoczi <address@hidden> wrote:
> 
> >>     assert(progress || busy);
> >>-    return true;
> >>+    return progress;
> >
> >Now aio_poll() can return false when it used to return true?
> 
> I don't think that's a bug.
> 
> Firstly, this is the same thing you fixed and we discussed on another
> thread.

I'm fine with the change itself but it needs to be explained in the
commit message or a comment.

In the patch where I changed the semantics of aio_poll() the change is
explained in detail in the commit message:

http://patchwork.ozlabs.org/patch/261786/

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]