qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for union


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for unions
Date: Thu, 25 Jul 2013 17:19:52 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/23/2013 07:03 AM, Kevin Wolf wrote:
> This implements the visitor part of base types for unions. Parsed into
> QMP, this example schema definiton...

s/definiton/definition/

> 
>     { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } }
>     { 'type': 'BlockOptionsQcow2, 'data': { 'lazy-refcounts': 'bool' } }
> 
>     { 'union': 'BlockOptions',
>       'base': 'BlockOptionsBase',
>       'data': {
>           'raw': 'BlockOptionsRaw'
>           'qcow2': 'BlockOptionsQcow2'
>       } }
> 
> ...would describe the following JSON object:
> 
>     { "type": "qcow2",
>       "read-only": true,
>       "data": { "lazy-refcounts": false } }
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  scripts/qapi-visit.py | 30 +++++++++++++++++++++++++-----
>  1 file changed, 25 insertions(+), 5 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]