qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for union


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions
Date: Thu, 25 Jul 2013 17:12:32 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/23/2013 07:03 AM, Kevin Wolf wrote:
> The new 'base' key in a union definition refers to a struct type, which
> is inlined into the union definition and can represent fields common to
> all kinds.
> 
> For example the following schema definition...
> 
>     { 'type': 'BlockOptionsBase', 'data': { 'read-only': 'bool' } }
> 
>     { 'union': 'BlockOptions',
>       'base': 'BlockOptionsBase',
>       'data': {
>           'raw': 'BlockOptionsRaw'
>           'qcow2': 'BlockOptionsQcow2'
>       } }
> 
> ...would result in this generated C struct:
> 
>     struct BlockOptions
>     {
>         BlockOptionsKind kind;
>         union {
>             void *data;
>             BlockOptionsRaw * raw;
>             BlockOptionsQcow2 * qcow2;
>         };
>         bool read_only;
>     };
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  scripts/qapi-types.py | 16 ++++++++++++++--
>  1 file changed, 14 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]