Re: [Qemu-devel] [PATCH] kvm: migrate vPMU state

[Andreas Färber]

Am 25.07.2013 16:46, schrieb Andreas Färber:
> Am 25.07.2013 12:14, schrieb Gleb Natapov:
>> On Wed, Jul 24, 2013 at 05:01:15PM +0200, Andreas Färber wrote:
>>> New msr_* fields would be candidates for X86CPU, but there's already one
>>> in CPUX86State. :/
>>>
>> Is this NAK?
> 
> No, it was more an implicit question of whether Paolo had considered a
> different placement?
> 
> Since there is a uint64_t msr_ia32_misc_enable visible as precedent, I
> was thinking it would be better for consistency to do such movements as
> follow-up, if at all. However checking on that now, I do not have any
> msr_* there in my repo, and it is after CPU_COMMON, thus not reset -
> Paolo, what do you think?

Consider me confused, please ignore. msr_ia32_misc_enable is further
above and is *before* CPU_COMMON, thus moving it into X86CPU would
require zero'ing them on reset, so not as simple as a pure code movement
and s/env/cpu/g, so better leave it as is for now so short before v1.6
Hard Freeze.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg