[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round
From: |
Petar Jovanovic |
Subject: |
Re: [Qemu-devel] [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round |
Date: |
Mon, 22 Jul 2013 08:51:05 +0000 |
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 15, 2013 1:46 PM
To: Richard Henderson; Petar Jovanovic
Cc: address@hidden; address@hidden
Subject: RE: [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round
ping
________________________________________
From: Petar Jovanovic
Sent: Monday, July 08, 2013 11:14 AM
To: Richard Henderson; Petar Jovanovic
Cc: address@hidden; address@hidden
Subject: RE: [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round
ping
http://patchwork.ozlabs.org/patch/255967/
________________________________________
From: Richard Henderson address@hidden on behalf of Richard Henderson
address@hidden
Sent: Monday, July 01, 2013 4:52 PM
To: Petar Jovanovic
Cc: address@hidden; Petar Jovanovic; address@hidden
Subject: Re: [PATCH v2] target-mips: fix mipsdsp_trunc16_sat16_round
On 06/30/2013 04:54 PM, Petar Jovanovic wrote:
> From: Petar Jovanovic <address@hidden>
>
> This change corrects rounding and saturation of Q31 fractional value in
> mipsdsp_trunc16_sat16_round(). Overflow detection was incorrect for the
> corner case for PRECRQ_RS.PH, and this test case is also part of the change.
>
> Signed-off-by: Petar Jovanovic <address@hidden>
> ---
>
> v2:
>
> - added comments to the code
>
> target-mips/dsp_helper.c | 16 +++++++++++-----
> tests/tcg/mips/mips32-dsp/precrq_rs_ph_w.c | 24 ++++++++++++++++++++----
> 2 files changed, 31 insertions(+), 9 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~