[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a "map" subcommand
Date: Fri, 19 Jul 2013 13:36:50 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/16/2013 10:29 AM, Paolo Bonzini wrote:
> This command dumps the metadata of an entire chain, in either tabular or JSON
> format.
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>         v1->v2: mention encrypted clusters, use PRId64
>  qemu-img-cmds.hx |   6 ++
>  qemu-img.c       | 185 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 191 insertions(+)

Missing a change to qemu-img.texi to list the documentation required there.

It might also help to show a sample of the output in the commit message.

I didn't spot anything else beyond your other reviewers.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]