[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

From: Peter Lieven
Subject: Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()
Date: Fri, 19 Jul 2013 11:36:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7

On 19.07.2013 11:14, Kevin Wolf wrote:
Am 18.07.2013 um 10:37 hat Peter Lieven geschrieben:
Signed-off-by: Peter Lieven <address@hidden>
  block.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block.c b/block.c
index b560241..c7f0197 100644
--- a/block.c
+++ b/block.c
@@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t 
enabled = bs->io_limits_enabled;
      bs->io_limits_enabled = false;
-    ret = bdrv_read(bs, 0, buf, 1);
+    ret = bdrv_read(bs, sector_num, buf, nb_sectors);
      bs->io_limits_enabled = enabled;
      return ret;
Reviewed-by: Kevin Wolf <address@hidden>

The commit message would have deserved a comment about the impact. The
only caller is passing 0 as sector_num and 1 as nb_sectors, so this
doesn't change the behaviour in practice. (Which is the reason why it's
not for qemu-stable.)
Yes, I only spotted it while working on 4KN support.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]