[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/11] cpus: Let vm_stop[_force_state]() always flus
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 09/11] cpus: Let vm_stop[_force_state]() always flush block devices |
Date: |
Fri, 19 Jul 2013 16:38:50 +0800 |
From: Kevin Wolf <address@hidden>
Even if the VM is already stopped, we cannot assume that all data has
already been successfully flushed to disk. The flush during the previous
vm_stop() could have failed.
Run bdrv_flush_all() unconditionally so that we get an error each time
if the block device isn't really flushed.
Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
cpus.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/cpus.c b/cpus.c
index 8062cdd..2509eb5 100644
--- a/cpus.c
+++ b/cpus.c
@@ -443,11 +443,12 @@ static int do_vm_stop(RunState state)
pause_all_vcpus();
runstate_set(state);
vm_state_notify(0, state);
- bdrv_drain_all();
- ret = bdrv_flush_all();
monitor_protocol_event(QEVENT_STOP, NULL);
}
+ bdrv_drain_all();
+ ret = bdrv_flush_all();
+
return ret;
}
@@ -1126,7 +1127,9 @@ int vm_stop_force_state(RunState state)
return vm_stop(state);
} else {
runstate_set(state);
- return 0;
+ /* Make sure to return an error if the flush in a previous vm_stop()
+ * failed. */
+ return bdrv_flush_all();
}
}
--
1.8.1.4
- [Qemu-devel] [PULL for-1.6 00/11] Block patches, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 01/11] gluster: Use pkg-config to configure GlusterFS block driver, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 02/11] gluster: Add discard support for GlusterFS block driver., Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 03/11] dataplane: sync virtio.c and vring.c virtqueue state, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 04/11] QEMUBH: make AioContext's bh re-entrant, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 05/11] block: fix vvfat error path for enable_write_target, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 09/11] cpus: Let vm_stop[_force_state]() always flush block devices,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 08/11] block-migration: efficiently encode zero blocks, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 10/11] block: fix bdrv_read_unthrottled(), Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 11/11] block/raw: add .bdrv_get_info, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 07/11] block/raw: add bdrv_co_write_zeroes, Stefan Hajnoczi, 2013/07/19
- [Qemu-devel] [PATCH 06/11] block: add bdrv_write_zeroes(), Stefan Hajnoczi, 2013/07/19