[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 3/3] icount: create a new icount based timer.
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [RFC 3/3] icount: create a new icount based timer. |
Date: |
Thu, 18 Jul 2013 16:08:30 +0100 |
On 18 July 2013 16:02, <address@hidden> wrote:
> @@ -156,6 +156,12 @@ void restore_icount(CPUArchState *env, int save)
> /* Return the virtual CPU time, based on the instruction counter. */
> int64_t cpu_get_icount(void)
> {
> + return qemu_icount_bias + cpu_get_icount_wo_bias();
> +}
> +
> +/* Return the virtual CPU time, really based on the instruction counter. */
> +int64_t cpu_get_icount_wo_bias(void)
> +{
The comments for these two functions don't make any sense.
You need to explain what they're actually doing (and
when you'd want one and when the other).
-- PMM
- [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount., fred . konrad, 2013/07/18
- [Qemu-devel] [RFC 2/3] icount: sync vm_clock on the next event., fred . konrad, 2013/07/18
- [Qemu-devel] [RFC 3/3] icount: create a new icount based timer., fred . konrad, 2013/07/18
- Re: [Qemu-devel] [RFC 3/3] icount: create a new icount based timer.,
Peter Maydell <=
- Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount., Peter Maydell, 2013/07/18
- Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount., Frederic Konrad, 2013/07/29
- Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount., Paolo Bonzini, 2013/07/29
- Re: [Qemu-devel] [RFC 0/3] Determinitic behaviour with icount., Frederic Konrad, 2013/07/30