[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices
Date: Thu, 18 Jul 2013 07:02:11 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7

On 07/18/2013 06:55 AM, Kevin Wolf wrote:
> Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben:
>> Even if the VM is already stopped, we cannot assume that all data has
>> already been successfully flushed to disk. The flush during the previous
>> vm_stop() could have failed.
>> Run bdrv_flush_all() unconditionally so that we get an error each time
>> if the block device isn't really flushed.
> Oops, forgot it again:
> Cc: address@hidden
>> Signed-off-by: Kevin Wolf <address@hidden>
>> ---
>>  cpus.c | 9 ++++++---
>>  1 file changed, 6 insertions(+), 3 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]