[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup'
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup' |
Date: |
Wed, 17 Jul 2013 06:44:41 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/17/2013 03:42 AM, Fam Zheng wrote:
> Similar to drive-backup, but this command uses a device id as target
> instead of creating/opening an image file.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> blockdev.c | 71
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> qapi-schema.json | 49 ++++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 22 ++++++++++++++++++
> 3 files changed, 142 insertions(+)
>
> +++ b/qapi-schema.json
> @@ -1665,6 +1665,40 @@
> '*on-target-error': 'BlockdevOnError' } }
>
> ##
> +# @BlockdevBackup
> +#
> +{ 'type': 'BlockdevBackup',
> + 'data': { 'device': 'str', 'target': 'str',
> + 'sync': 'MirrorSyncMode',
> + '*speed': 'int',
> + '*on-source-error': 'BlockdevOnError',
> + '*on-target-error': 'BlockdevOnError' } }
Seems okay. But what is missing is the addition of this type into the
union used for 'transaction' - shouldn't it be possible to mix this with
other transaction capabilities?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, (continued)
- [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Fam Zheng, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Kevin Wolf, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Paolo Bonzini, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 10/11] block: add option 'backing' to -drive options, Fam Zheng, 2013/07/22
[Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup', Fam Zheng, 2013/07/17
- Re: [Qemu-devel] [PATCH v2 11/11] qmp: add command 'blockdev-backup',
Eric Blake <=
Re: [Qemu-devel] [PATCH v2 00/11] Point-in-time snapshot exporting over NBD, Wenchao Xia, 2013/07/19