[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write

From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target
Date: Wed, 17 Jul 2013 12:24:48 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130621 Thunderbird/17.0.7

On 07/17/13 11:57, Fam Zheng wrote:
> s->qcow and s->qcow_filename are allocated but not freed on error. Fix the
> possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of
> bdrv_create() and also the one of enable_write_target().
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> v2: Fix leak of s->qcow_filename, propagate returen value of
>     enable_write_target(). [Laszlo]
> ---
>  block/vvfat.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)

Looks good to me.

Reviewed-by: Laszlo Ersek <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]