[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages |
Date: |
Tue, 16 Jul 2013 10:28:02 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
On 07/15/2013 08:43 PM, Stefan Hajnoczi wrote:
> On Tue, Jul 09, 2013 at 03:30:13PM +0800, Qiao Nuohan wrote:
>> if test "$seccomp" != "no" ; then
>> @@ -3872,6 +3914,14 @@ if test "$glx" = "yes" ; then
>> echo "GLX_LIBS=$glx_libs" >> $config_host_mak
>> fi
>>
>> +if test "$lzo" = "yes" ; then
>> + echo "CONFIG_LZO=y" >> $config_host_mak
>> +fi
>> +
>> +if test "$snappy" = "yes" ; then
>> + echo "CONFIG_SNAPPY=y" >> $config_host_mak
>> +fi
>
> Please also include a run-time check so QEMU can produce an error when a
> user chooses a compression algorithm which is not built in. For
> example, the user should get a clear error when they select Snappy but
> QEMU was built without Snappy support.
Here's an instance where runtime introspection would come in handy -
knowing which values of an enum are actually supportable, vs. the entire
list of names but relying on decent errors for the elements that weren't
compiled in.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v5 2/9] dump: Add API to write header of flatten format, (continued)
- [Qemu-devel] [PATCH v5 3/9] dump: Add API to write vmcore, Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 7/9] dump: Add APIs to operate DataCache, Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 4/9] dump: Add API to write elf notes to buffer, Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 6/9] dump: Add API to write dump_bitmap, Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory', Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 8/9] dump: Add API to write dump pages, Qiao Nuohan, 2013/07/09
- [Qemu-devel] [PATCH v5 5/9] dump: add API to write dump header, Qiao Nuohan, 2013/07/09
- Re: [Qemu-devel] [PATCH v5 0/9] Make 'dump-guest-memory' dump in kdump-compressed format, Qiao Nuohan, 2013/07/09