[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-devel] [RFC PATCH v1 1/2] gluster: Use pkg-config to configure GlusterFS block driver |
Date: |
Tue, 16 Jul 2013 17:04:45 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 16, 2013 at 10:25:29AM +0200, Kevin Wolf wrote:
> > - glusterfs_libs="-lgfapi -lgfrpc -lgfxdr"
> > - if compile_prog "" "$glusterfs_libs" ; then
> > - glusterfs=yes
> > - libs_tools="$glusterfs_libs $libs_tools"
> > - libs_softmmu="$glusterfs_libs $libs_softmmu"
> > + if $pkg_config --atleast-version=3 glusterfs-api >/dev/null 2>&1; then
> > + glusterfs="yes"
> > + glusterfs_cflags=`$pkg_config --cflags glusterfs-api 2>/dev/null`
> > + glusterfs_libs=`$pkg_config --libs glusterfs-api 2>/dev/null`
> > + CFLAGS="$CFLAGS $glusterfs_cflags"
> > + LIBS="$LIBS $glusterfs_libs"
>
> Why do you switch from libs_tools/libs_softmmu to LIBS? If I understand
> it right, this means that you now link the library to linux-user targets
> as well, but I can't see how they need it.
Copied from some other backend and didn't realize that I ended up considering
linux-user target also. Will change this and send v2.
Regards,
Bharata.
[Qemu-devel] [RFC PATCH v1 2/2] gluster: Add discard support for GlusterFS block driver, Bharata B Rao, 2013/07/12