qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory c


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v3 11/14] ioport: Switch dispatching to memory core layer
Date: Fri, 12 Jul 2013 16:30:24 +0200


Am 12.07.2013 um 14:56 schrieb Anthony Liguori <address@hidden>:

> Alexander Graf <address@hidden> writes:
> 
>> On 11.07.2013, at 14:29, Alexander Graf wrote:
>> 
>>> This patch breaks VGA on PPC as it is in master today.
>> 
>> If I don't mark portio as little endian it works as expected. There's
>> probably someone swapping things twice.
> 
> This is the correct fix.  Can you please send a patch?

I only have my phone with me right now. The problem is that we need to

  1) revert the ioport access ops back to native
  2) fix the le assumption for the w-on-b emulation case

Alex

> 
> I/O dispatch functions take a native endian argument and when
> cpu_{in,out][bwl] is called it's passed a native endian argument.  There
> is no need to ever byte swap.
> 
> The ISA bus is going to have data pins numbered D0..D15.  There is no
> concept of endianness.  D0 is the LSB.  How the CPU stores bytes in
> memory is orthogonal to what is happening on the bus.
> 
> Regards,
> 
> Anthony Liguori
> 
>> 
>> 
>> Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]