[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-nee
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH qom-next v2 1/5] target-arm/cpu.c: delete un-needed instance/class sizes |
Date: |
Thu, 11 Jul 2013 10:07:24 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 11.07.2013 03:45, schrieb address@hidden:
> From: Peter Crosthwaite <address@hidden>
>
> QOM automatically inherits class and instance size from the parent
> class. No need to redefine as the same value as the parent.
Quoting my original comment:
"It would be fair to mention since which commit because that was
originally not the case."
http://git.qemu.org/?p=qemu.git;a=commit;h=aca59af612840772f18598363b65a25bf02bb569
E.g., "By now, QOM automatically..." or "Since commit ..."
>
> CC: address@hidden
We have an active ARM maintainer, so no reason to involve qemu-trivial
here by our definition. Possibly that would've required Cc: anyway? Not
actually CC'ed.
>
> Signed-off-by: Peter Crosthwaite <address@hidden>
Still:
Reviewed-by: Andreas Färber <address@hidden>
PMM, do you want to pick this one up for target-arm.next? The rest
depends on central infrastructure under discussion. Suggest renaming to
"target-arm: Delete un-needed instance/class sizes for ARMCPU
subclasses" for simplicity and so that it aligns nicely with others.
Regards,
Andreas
> ---
>
> target-arm/cpu.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/target-arm/cpu.c b/target-arm/cpu.c
> index 1bc227e..ed53df8 100644
> --- a/target-arm/cpu.c
> +++ b/target-arm/cpu.c
> @@ -823,9 +823,7 @@ static void cpu_register(const ARMCPUInfo *info)
> {
> TypeInfo type_info = {
> .parent = TYPE_ARM_CPU,
> - .instance_size = sizeof(ARMCPU),
> .instance_init = info->initfn,
> - .class_size = sizeof(ARMCPUClass),
> .class_init = info->class_init,
> };
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH qom-next v2 4/5] target-microblaze: Use parent class for reset + realize, peter . crosthwaite, 2013/07/10