Re: [Qemu-devel] [PATCH V2 0/5] Add infinite loop check for backing file chain

[Fam Zheng]

On Mon, 07/08 03:26, Xu Wang wrote:
> Updates:
>   1. Changed infinite loop check in collect_image_info_list() from filename
>      checking to inode checking.
>   2. Absolute or relative path is OK for filename path.
>   3. Hard and soft link are works well.
>   4. Added WIN32 platform support (shortcuts could be recognized correctly.)
>   5. Create a file which contains loop in backing file will failed.
>   6. Start a vm which boot block file contains loop in backing file chain
>      will failed instead of no response and segment fault.
> 
> Xu Wang (5):
>   Refine and export infinite loop checking in collect_image_info_list()
>   Add WIN32 platform support for backing_file_loop_check()
>   Check infinite loop in bdrv_img_create()
>   Add backing file loop check in change_backing_file()
>   Add infinite loop check in drive_init()
> 
>  block.c               | 211 
> ++++++++++++++++++++++++++++++++++++++++++++++++--
>  blockdev.c            |   5 ++
>  include/block/block.h |   4 +
>  qemu-img.c            |  30 +++----
>  4 files changed, 224 insertions(+), 26 deletions(-)
> 

Thanks for the series. I made a few comments on each patch. You hashed
windows full path to get the "inode", but case sensitively, would that
work with the same files of different case?

Please prefix your commit message with "block:" or "qemu-img:",
e.g.:

    block: refactor collect_image_info_list()
    block: Add WIN32 platform support for backing_file_loop_check()
    etc..

and maybe also describe some of the long patches, explaining what is
changed.

Also please consider to write some test case on your changes, as requested
in the replies to previous version.

-- 
Fam