|
From: | Alex Bligh |
Subject: | Re: [Qemu-devel] [PATCH v5] Xen PV Device |
Date: | Mon, 08 Jul 2013 15:19:43 +0100 |
--On 8 July 2013 15:10:49 +0100 Peter Maydell <address@hidden> wrote:
You probably mean Reviewed-by. Acked-by really means, "I am not the maintainer of this area, I have not reviewed this patch, but I am generally okay with the idea as best I can tell."Don't you mean "I *am* the maintainer of this area" ? I've always assumed it means "as the maintainer I have a potential veto over this code change and I am explicitly not exercising it even though I may not have done a complete review and/or test"...
Really? That would imply no one should add Acked-By except maintainers. That's not right according to: https://github.com/torvalds/linux/blob/master/Documentation/SubmittingPatches#L397 The use at line 401 by maintainers does not seem to me to be 'exclusive'. For instance, I've used Acked-by when someone else modifies a piece of code I've contributed (e.g. to fix a bug), to indicate I agree with them. It's also pretty clear (line 437 and 462) what Reviewed-by: means -- Alex Bligh
[Prev in Thread] | Current Thread | [Next in Thread] |