[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate |
Date: |
Fri, 5 Jul 2013 09:00:11 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, 07/04 16:02, Stefan Hajnoczi wrote:
> On Tue, Jul 02, 2013 at 01:59:46PM +0800, Fam Zheng wrote:
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> > block.c | 71
> > ++++++++++-------------------------------------------------------
> > 1 file changed, 11 insertions(+), 60 deletions(-)
>
> Way too big for no commit description. Okay, I admit I jumped into this
> patch and didn't review all the previous ones - maybe it would have been
> obvious if I had read them linearly :).
>
> Should the description be something like "We no longer need to a keep a
> list because refcounts ..."?
>
Yes, will add a decent message.
Thanks.
--
Fam
- Re: [Qemu-devel] [PATCH 1/7] block: Convert BlockDriverState.in_use to refcount, (continued)
[Qemu-devel] [PATCH 4/7] block: simplify bdrv_drop_intermediate, Fam Zheng, 2013/07/02
[Qemu-devel] [PATCH 5/7] block: rename bdrv_in_use to bdrv_is_shared, Fam Zheng, 2013/07/02
[Qemu-devel] [PATCH 6/7] block: add target-id option to drive-backup QMP command, Fam Zheng, 2013/07/02
[Qemu-devel] [PATCH 7/7] block: assign backing relationship in drive-backup, Fam Zheng, 2013/07/02