Re: [Qemu-devel] [PATCH V3 5/9] qmp: add interface blockdev-snapshot-internal-sync

[Stefan Hajnoczi]

On Thu, Jun 27, 2013 at 10:41:44AM +0800, Wenchao Xia wrote:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 2547a7d..fba9b15 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -1738,6 +1738,28 @@
>              '*mode': 'NewImageMode'} }
>  
>  ##
> +# @blockdev-snapshot-internal-sync
> +#
> +# Synchronously take an internal snapshot of a block device, when the format
> +# of the image used supports it.
> +#
> +# @device: the name of the device to generate the snapshot from
> +#
> +# @name: the name of new snapshot name
> +#
> +# Returns: nothing on success
> +#          If @device is not a valid block device, DeviceNotFound
> +#          If any snapshot matching @name exists, or the name string is 
> invalid
> +#          which may mess up with snapshot ID, or name is empty, GenericError

s/mess up with snapshot ID/collide with snapshot IDs/

> +image used supports it.  If the name is a numeric string which may mess up 
> with

Same here.