[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros |
Date: |
Thu, 4 Jul 2013 11:53:28 +0100 |
On 3 July 2013 22:29, Richard Henderson <address@hidden> wrote:
> This allows TCG_TARGET_HAS_* to be a variable rather than a constant,
> which allows easier support for differing ISA levels for the host.
The effect of this is that TCG_OPF_NOT_PRESENT means "if set,
op is definitely not present; if not set, op might or might
not be present", right? Which is OK because it's just a debug
guard/sanity check. (That might be worth noting in a comment
I guess.)
Reviewed-by: Peter Maydell <address@hidden>
-- PMM
- [Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 01/14] tcg: Add myself to general TCG maintainership, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 02/14] tcg: Split rem requirement from div requirement, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 03/14] tcg-arm: Don't implement rem, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 04/14] tcg-ppc: Don't implement rem, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 05/14] tcg-ppc64: Don't implement rem, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros, Richard Henderson, 2013/07/03
- Re: [Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 07/14] tcg: Simplify logic using TCG_OPF_NOT_PRESENT, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 08/14] tcg-arm: Make use of conditional availability of opcodes for divide, Richard Henderson, 2013/07/03
- [Qemu-devel] [PATCH v3 09/14] tcg-arm: Simplify logic in detecting the ARM ISA in use, Richard Henderson, 2013/07/03