Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

[Fam Zheng]

On Thu, 07/04 10:16, Paolo Bonzini wrote:
> Il 04/07/2013 07:34, Fam Zheng ha scritto:
> >> > +        if ((e->flags & (BDRV_BLOCK_DATA|BDRV_BLOCK_ZERO)) == 
> >> > BDRV_BLOCK_DATA) {
> >> > +            printf("%lld %lld %d %lld\n",
> >> > +                   (long long) e->start, (long long) e->length,
> >> > +                   e->depth, (long long) e->offset);
> >> > +        }
> > Why %lld and explicit cast, not using PRId64?
> 
> Will fix.
> 
> > Is BDRV_BLOCK_DATA and BDRV_BLOCK_ZERO distinguishable here for the
> > user? By offset?
> 
> I'm not sure I understand the question.
> 
> Zero blocks are always omitted in the "human" format.  Only non-zero
> blocks are listed.
I missed this.

-- 
Fam