Re: [Qemu-devel] [PATCH] Citrix PV Bus device

[Paul Durrant]

> -----Original Message-----
> From: Peter Maydell [mailto:address@hidden
> Sent: 02 July 2013 15:58
> To: Paul Durrant
> Cc: address@hidden; address@hidden
> Subject: Re: [Qemu-devel] [PATCH] Citrix PV Bus device
> 
> On 2 July 2013 15:03, Paul Durrant <address@hidden> wrote:
> > This patch introduces a new PCI device which will act as the binding point
> > for Citrix branded PV drivers for Xen.
> > The intention is that Citrix Windows PV drivers will be available on Windows
> > Update and thus using the existing Xen platform PCI device as an anchor
> > point is not desirable as that device has been ubiquitous in HVM guests for
> > a long time and thus existing HVM guests running Windows would start
> > automatically downloading drivers from Windows Update when this may
> not be
> > desired by either the host or guest admin. This device therefore acts as
> > an opt-in for those wishing to deploy Citrix PV drivers.
> 
> This commit message doesn't really make the case for having this
> driver in upstream, IMHO. It sounds like it's only of use for your
> branded product, which suggests that the best place for it is
> probably in your product, not upstream.
> 

No, that's not true. The drivers themselves may be Citrix branded but they are 
not solely for use in Citrix branded VMs.

  Paul