[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type conversion
Date: Tue, 2 Jul 2013 14:44:56 +0100

On 1 July 2013 01:44, Petar Jovanovic <address@hidden> wrote:
> The patch also includes necessary code style changes (tab to spaces) in the
> header file since most of the file has been touched by this change.

This makes it pretty painful to review because of all the "not actually
changing anything" changes. If you want to fix up indent on an entire
file that would be better as a single patch on its own before this
one; then it's easy to check that that has no actual code change,
and the patch with the code changes is smaller and easier to read.

(The general rule of thumb is "if you're just changing a few lines
of indent/braces in lines that the patch touches anyway" that's fine;
larger scale changes go in their own patch if we do them at all.)

Not using the same base as the kernel (hex vs octal) made checking
the values a bit tedious too, but I think they're all correct.

That said,
Reviewed-by: Peter Maydell <address@hidden>

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]