[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] [slirp] add nextserver support in slirp's dhcp-
From: |
Bas van Sisseren |
Subject: |
Re: [Qemu-devel] [PATCH] [slirp] add nextserver support in slirp's dhcp-server |
Date: |
Tue, 02 Jul 2013 15:03:11 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 01/07/13 22:51, Eric Blake wrote:
> On 06/21/2013 07:20 AM, Bas van Sisseren wrote:
>> The slirp dhcp-server normally returns its own address as tftp
>> nextserver for netbooting. This patch makes that address
>> configurable, so it is possible to use an external tftp boot-
>> environment.
>>
>> Signed-off-by: Bas van Sisseren <address@hidden>
>> ---
>> net/slirp.c | 10 ++++++++--
>
>> +++ b/qapi-schema.json
>> @@ -2537,6 +2537,8 @@
>> # @dhcpstart: #optional the first of the 16 IPs the built-in DHCP server can
>> # assign
>> #
>> +# @nextserver: #optional IP address of BOOTP server
>> +#
>
> Please mark this field as '(since 1.6)'.
Added in my local checkout. I now have to find out how to generate a new
patch and post it into this thread. I'll try to post a new patch somewhere
in the next days. (I'm new to git :-) )
> Does the field work for both IPv4 and IPv6 addresses?
This setting is IPv4 only. (btw, I think all slirp settings are IPv4 only)
>> # @dns: #optional guest-visible address of the virtual nameserver
>> #
>> # @dnssearch: #optional list of DNS suffixes to search, passed as DHCP
>> option
>> @@ -2563,6 +2565,7 @@
>> '*tftp': 'str',
>> '*bootfile': 'str',
>> '*dhcpstart': 'str',
>> + '*nextserver': 'str',
>
> This is a command addition that libvirt can't take advantage of unless
> we get introspection working in a timely manner.
It would be a nice addition to libvirt, but is it a problem that libvirt
doesn't support all new settings (yet)?
Met vriendelijke groet,
Bas van Sisseren
- --
Bas van Sisseren <address@hidden>
Quarantainenet
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iEYEARECAAYFAlHSz4sACgkQ19+8tHrpflo3gACgjHd8ApumOrsxN4Wv9nPxsvoJ
r6QAnjTKcoxJ6M3q5oZxauNmFsseYw5b
=rirP
-----END PGP SIGNATURE-----