Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device

[Paul Durrant]

> -----Original Message-----
> From: Jan Beulich [mailto:address@hidden
> Sent: 02 July 2013 09:46
> To: Paul Durrant
> Cc: address@hidden; address@hidden
> Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device
> 
> >>> On 02.07.13 at 10:39, Paul Durrant <address@hidden> wrote:
> > --- a/include/hw/pci/pci_ids.h
> > +++ b/include/hw/pci/pci_ids.h
> > @@ -151,4 +151,7 @@
> >  #define PCI_VENDOR_ID_TEWS               0x1498
> >  #define PCI_DEVICE_ID_TEWS_TPCI200       0x30C8
> >
> > +#define PCI_VENDOR_ID_CITRIX             0x5853
> 
> Is that really the right way to do things, considering that the same
> value is elsewhere used for PCI_VENDOR_ID_XEN?
> 
> Jan
> 
> > +#define PCI_DEVICE_ID_CITRIX_PV_BUS      0x0002
> > +
> >  #endif
> 

I opted to do this for clarity. The fact that the Xen platform device uses 
Citrix's vendor ID is historical; I wanted to be clear that this device was 
distinct.

  Paul