[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory"
|
From: |
Anthony Liguori |
|
Subject: |
Re: [Qemu-devel] [PATCH 4/4] qapi: Rename ChardevBackend member "memory" to "ringbuf" |
|
Date: |
Mon, 01 Jul 2013 07:52:27 -0500 |
|
User-agent: |
Notmuch/0.15.2+77~g661dcf8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Markus Armbruster <address@hidden> writes:
> Amos Kong <address@hidden> writes:
>
>> On Mon, Jul 01, 2013 at 10:10:40AM +0200, Markus Armbruster wrote:
>>> Amos Kong <address@hidden> writes:
>>>
>> The comment line in your patch doen't start with '#', it starts with
>> blank-space. If we want qapi.py to process it, we need to do strip()
>> first.
>
> Aha. I agree with your reading of parse_schema(). However, I get
> exactly identical generated files with and without this comment.
>
> Michael, Anthony, can you explain why?
>
> Any particular reason for requiring comments to start in column 0?
I don't remember a particular reason. Most likely an evolutionary
artifact.
Regards,
Anthony Liguori