Re: [Qemu-devel] [PATCH 00/26] use realizefn for SysBusDevice, part 1

[Andreas Färber]

Hi,

Am 22.06.2013 10:50, schrieb Hu Tao:
> This series updates part of devices inheriting from SysbusDevice
> to use DeviceState::realize, and QOM'ify them.
> 
> These devices are default to x86_64-softmmu. I'm planning to
> make patches in the same manner, that is, each series is for
> devices default to each target. After all devices are converted
> to realizefn, SysBusDevice::init can be removed.

This series looks promising. As was requested by others, please rebase
(possibly on qom-next if there's conflicts with Peter M.'s patch?) and
reorder the patches so that QOM cast macros come before more functional
changes (the former can be picked up more quickly).

For ARM I am looking into a few devices surrounding cpu/a9mpcore.c.
Paolo has announced a PULL for his MemoryRegion refactorings for
beginning of the week, which is likely to conflict with realizefn work.

As a reminder for realize series (we should definitely document this!):
* QOM realize functions should not create new devices as that creates
problems with recursive realized = true and will prohibit changing
static device properties through QMP. (Therefore more review work.)
* Care must be taken with bus creation since qbus_create[_inplace]() /
qbus_realize() check for DeviceState::id, which is still NULL at
instance_init time. (OHCI looked good for instance.)

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg