qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] cpu: Drop unnecessary dynamic casts in *_env


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2] cpu: Drop unnecessary dynamic casts in *_env_get_cpu()
Date: Fri, 28 Jun 2013 10:32:49 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130612 Thunderbird/17.0.6

On 06/28/2013 06:23 AM, Andreas Färber wrote:
> A transition from CPUFooState to FooCPU can be considered safe,
> just like FooCPU::env access in the opposite direction.
> The only benefit of the FOO_CPU() casts would be protection against
> bogus CPUFooState pointers, but then surrounding code would likely
> break, too.
> 
> This should slightly improve interrupt etc. performance.
> 
> Reported-by: Anthony Liguori <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>

Acked-by: Richard Henderson <address@hidden>


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]