[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with d
Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup
Thu, 27 Jun 2013 12:06:44 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6
Il 27/06/2013 10:17, Stefan Hajnoczi ha scritto:
>>> > > Il 26/06/2013 05:59, Fam Zheng ha scritto:
>>> > > This leads to another observation: a sync:'none' block-backup job
>>> > > probably should never complete, and should instead go on until explicit
>>> > > cancellation. This is because the job does no background writes, and
>>> > > thus completion would only happen after the guest has written the whole
>>> > > disk. Writing the whole disk is rare enough that it will likely cause
>>> > > bugs in the clients. It is easier just to never complete the job.
>>> > >
>> > Yes, the sync mode none will simply run forever until cancelled.
> There is a dedicated command to successfully complete a job:
block-job-complete should only be called after a BLOCK_JOB_READY event,
but when would the backup job raise it? Immediately after starting?
There is no behavioral difference in this case between cancel and
complete in fact as far as I understand, so I think cancelling the job
would match existing practice better.
[Qemu-devel] [RFC PATCH 2/3] block: assign backing relationship in drive-backup, Fam Zheng, 2013/06/26
[Qemu-devel] [RFC PATCH 3/3] nbd: don't get ref if bs has no drive, Fam Zheng, 2013/06/26
Re: [Qemu-devel] [RFC PATCH 0/3] Point-in-time snapshot exporting with drive-backup, Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [RFC PATCH 1/3] block: add target-id option to drive-backup QMP command, (continued)