Re: [Qemu-devel] [PATCH] vmdk: remove wrong calculation of relative path

[Kevin Wolf]

Am 26.06.2013 um 11:24 hat Fam Zheng geschrieben:
> When creating image with backing file, the driver tries to calculate the
> relative path from created image file to backing file, but the path
> computation is incorrect. e.g.:
> 
>     $ qemu-img create -f vmdk -b vmdk-data-disk.vmdk vmdk-data-snapshot1
>     Formatting 'vmdk-data-snapshot1', fmt=vmdk size=10737418240
>     backing_file='vmdk-data-disk.vmdk' compat6=off zeroed_grain=off
> 
>     $ qemu-img info vmdk-data-snapshot1
>     image: vmdk-data-snapshot1
>     file format: vmdk
>     virtual size: 10G (10737418240 bytes)
>     disk size: 12K
> ->  backing file: disk.vmdk
> 
> The common part in file names, "vmdk-data-", is incorrectly forgotten by
> relative_path(). As the VMDK specification has no restriction on
> parentNameHint to be relative path, we simply remove this by using the
> backing_file option.
> 
> Signed-off-by: Fam Zheng <address@hidden>

Nice one. Thanks, applied to the block branch.

Kevin