[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/6] pc: Don't explode QEMUMachineInitArgs into l
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 2/6] pc: Don't explode QEMUMachineInitArgs into local variables needlessly |
Date: |
Wed, 26 Jun 2013 16:13:03 +0200 |
Don't explode when the variable is used just a few times, and never
changed.
Signed-off-by: Markus Armbruster <address@hidden>
---
hw/i386/pc_q35.c | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index bb0ce6a..158708e 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -51,12 +51,6 @@ static bool has_pvpanic = true;
/* PC hardware initialisation */
static void pc_q35_init(QEMUMachineInitArgs *args)
{
- ram_addr_t ram_size = args->ram_size;
- const char *cpu_model = args->cpu_model;
- const char *kernel_filename = args->kernel_filename;
- const char *kernel_cmdline = args->kernel_cmdline;
- const char *initrd_filename = args->initrd_filename;
- const char *boot_device = args->boot_device;
ram_addr_t below_4g_mem_size, above_4g_mem_size;
Q35PCIHost *q35_host;
PCIBus *host_bus;
@@ -82,17 +76,17 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
object_property_add_child(qdev_get_machine(), "icc-bridge",
OBJECT(icc_bridge), NULL);
- pc_cpus_init(cpu_model, icc_bridge);
+ pc_cpus_init(args->cpu_model, icc_bridge);
pc_acpi_init("q35-acpi-dsdt.aml");
kvmclock_create();
- if (ram_size >= 0xb0000000) {
- above_4g_mem_size = ram_size - 0xb0000000;
+ if (args->ram_size >= 0xb0000000) {
+ above_4g_mem_size = args->ram_size - 0xb0000000;
below_4g_mem_size = 0xb0000000;
} else {
above_4g_mem_size = 0;
- below_4g_mem_size = ram_size;
+ below_4g_mem_size = args->ram_size;
}
/* pci enabled */
@@ -107,8 +101,10 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
/* allocate ram and load rom/bios */
if (!xen_enabled()) {
- pc_memory_init(get_system_memory(), kernel_filename, kernel_cmdline,
- initrd_filename, below_4g_mem_size, above_4g_mem_size,
+ pc_memory_init(get_system_memory(),
+ args->kernel_filename, args->kernel_cmdline,
+ args->initrd_filename,
+ below_4g_mem_size, above_4g_mem_size,
rom_memory, &ram_memory);
}
@@ -193,7 +189,7 @@ static void pc_q35_init(QEMUMachineInitArgs *args)
0xb100),
8, NULL, 0);
- pc_cmos_init(below_4g_mem_size, above_4g_mem_size, boot_device,
+ pc_cmos_init(below_4g_mem_size, above_4g_mem_size, args->boot_device,
floppy, idebus[0], idebus[1], rtc_state);
/* the rest devices to which pci devfn is automatically assigned */
--
1.7.11.7
- [Qemu-devel] [PATCH v2 0/6] Clean up bogus default boot order, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v2 4/6] ppc: Don't explode QEMUMachineInitArgs into local variables needlessly, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v2 1/6] pc: Don't prematurely explode QEMUMachineInitArgs, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v2 2/6] pc: Don't explode QEMUMachineInitArgs into local variables needlessly,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 5/6] ppc: Don't duplicate QEMUMachineInitArgs in PPCE500Params, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v2 3/6] sun4: Don't prematurely explode QEMUMachineInitArgs, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v2 6/6] hw: Clean up bogus default boot order, Markus Armbruster, 2013/06/26