[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 01/12] qtest: Don't reset on qtest chardev connec
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v4 01/12] qtest: Don't reset on qtest chardev connect |
Date: |
Wed, 26 Jun 2013 15:52:12 +0200 |
libqtest's qtest_init() connecting to the qtest socket triggers reset.
This was coded in the hope we could use the same QEMU process for
multiple tests that way. Never used. Injects an extra reset even
when it's not used, and that can mess up tests such as the one of
-boot once I'm about to add. Drop it.
Signed-off-by: Markus Armbruster <address@hidden>
---
qtest.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/qtest.c b/qtest.c
index 07a9612..74f1842 100644
--- a/qtest.c
+++ b/qtest.c
@@ -472,7 +472,12 @@ static void qtest_event(void *opaque, int event)
switch (event) {
case CHR_EVENT_OPENED:
- qemu_system_reset(false);
+ /*
+ * We used to call qemu_system_reset() here, hoping we could
+ * use the same process for multiple tests that way. Never
+ * used. Injects an extra reset even when it's not used, and
+ * that can mess up tests, e.g. -boot once.
+ */
for (i = 0; i < ARRAY_SIZE(irq_levels); i++) {
irq_levels[i] = 0;
}
--
1.7.11.7
- [Qemu-devel] [PATCH v4 00/12] Boot order tests, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 03/12] libqos: include dependencies, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 09/12] boot-order-test: Add tests for PowerPC PREP, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 10/12] boot-order-test: Add tests for Sun4m, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 02/12] boot-order-test: New; covering just PC for now, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 05/12] boot-order-test: Add tests for PowerMacs, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 01/12] qtest: Don't reset on qtest chardev connect,
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 04/12] libqos: Add support for memory-mapped fw_cfg, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 11/12] libqos: Generalize I/O-mapped fw_cfg, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 08/12] boot-order-test: Code motion for better readability, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 06/12] boot-order-test: Cover -boot once in ppc tests, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 12/12] boot-order-test: Add tests for Sun4u, Markus Armbruster, 2013/06/26
- [Qemu-devel] [PATCH v4 07/12] boot-order-test: Better separate target-specific and generic parts, Markus Armbruster, 2013/06/26