[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 0/3] spapr: Fix remaining compiler warnings |
|
Date: |
Wed, 26 Jun 2013 10:14:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 |
Il 24/06/2013 19:48, Stefan Weil ha scritto:
> Hi Alex,
>
> this mini series fixes the remaining compiler warnings in
> my w32/w64 cross build environment on Debian wheezy.
>
> [PATCH 1/3] spapr: Use named enum for function remove_hpte
> [PATCH 2/3] spapr: Fix compiler warning for some versions of gcc
> [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc
>
> The modifications are nearly trivial, but this time it would
> be better if you could apply them to your patch queue.
I think these patches are a bit backwards.
The right fix is just to use abort() instead of assert(0).
Paolo