qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH v3 1/2] net: introduce RX_FILTER_CHANGED event
Date: Wed, 26 Jun 2013 08:54:46 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 05/23/2013 03:07 AM, Amos Kong wrote:
>> Introduce this new QMP event to notify management after guest changes
>> rx-filter configuration.
>> 
>> Signed-off-by: Amos Kong <address@hidden>
>> ---
>>  QMP/qmp-events.txt        | 14 ++++++++++++++
>>  include/monitor/monitor.h |  1 +
>>  monitor.c                 |  1 +
>>  3 files changed, 16 insertions(+)
>> 
>> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
>> index 92fe5fb..ad6612b 100644
>> --- a/QMP/qmp-events.txt
>> +++ b/QMP/qmp-events.txt
>> @@ -154,6 +154,20 @@ Data:
>>              "path": "/machine/peripheral/virtio-net-pci-0" },
>>    "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
>>  
>> +RX_FILTER_CHANGED
>> +-----------------
>
>> +
>>  DEVICE_TRAY_MOVED
>>  -----------------
>
> Isn't this file supposed to be kept in sorted order, to minimize merge
> conflicts when backporting events?

Yes, please.  Also helps humans navigate.

GUEST_PANICKED is out of order, needs fixing.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]