[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant

From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v5] QEMUBH: make AioContext's bh re-entrant
Date: Tue, 25 Jun 2013 11:40:21 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 25.06.2013 um 19:26 hat Liu Ping Fan geschrieben:
> BH will be used outside big lock, so introduce lock to protect
> between the writers, ie, bh's adders and deleter. The lock only
> affects the writers and bh's callback does not take this extra lock.
> Note that for the same AioContext, aio_bh_poll() can not run in
> parallel yet.
> Signed-off-by: Liu Ping Fan <address@hidden>
> ---------

Please use exactly three dashes so that 'git am' recognises it as the
end of the commit message.

This doesn't compile yet because smp_read_barrier_depends() isn't merged
yet, so maybe there's still time for some nitpicking: Wouldn't using
atomic_set/get better document things and make them easier to read?

It should be correct anyway, so:

Reviewed-by: Kevin Wolf <address@hidden>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]