Re: [Qemu-devel] [PATCH v4 00/10] qemu-ga: fsfreeze on Windows using VSS

[Tomoki Sekiyama]

Any other comments for this series?


On 6/6/13 11:06 , "Tomoki Sekiyama" <address@hidden> wrote:
>Hi,
>
>This patch series adds fsfreeze support for Windows qemu-guest-agent.
>
>changes from v3:
> -[01/10] Use c++ instead of g++ in configureing C++ compiler if neither
>          $cross_prefix nor $CXX is specified.
> -[02/10] Add "alternative representations" as a reserved keywords in
>qapi.py.
> -[03/10 (newly added)] modify check-patch.pl to check C++ source code
> -[04/10] Improve compatibility (POSIX-compliant).
> -[04/10] Added some error checks.
> -[05/10] Added --with-win-sdk option to configure path to Windows SDK.
> -[06/10] Patch v3 09/11 (adding binary .tlb file) is squashed into this
>patch
>          in order to avoid git-bisect failure.
> -[06/10 & 07/10] Fix coding style.
> -Dropped Patch v3 11/11 (encode error desc of exception with current
>locale)
>
>changes from v2:
> -[06/11] Fix errors in Windows 7, reported by Li Baiqing
>
>changes from v1: 
> - Fix out-tree build by stop using recursive Makefile
> - Added script to extract VSS SDK headers on POSIX systems using msitools
>   (thanks Paolo)
> - Remove some unnecessary header files
>
>v3: http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg02771.html
>
>
>* Description
>  In Windows, VSS (Volume Shadow Copy Service) provides a facility to
>  quiesce filesystems and applications before disk snapshots are taken.
>  This patch series implements "fsfreeze" command of qemu-ga using VSS.
>
>
>* How to build & run qemu-ga with VSS support
>
> - Download Microsoft VSS SDK from:
>   http://www.microsoft.com/en-us/download/details.aspx?id=23490
>
> - Setup the SDK
>   scripts/extract-vsssdk-headers setup.exe (on POSIX-systems)
>
> - Specify installed SDK directory to configure option as:
>   ./configure -with-vss-sdk="path/to/VSS SDK"
>--cross-prefix=i686-w64-mingw32-
>
> - make qemu-ga.exe
>
> - Install qemu-ga.exe, qga/vss-win32-provider/qga-provider.{dll,tlb}, and
>   the other required mingw libraries into the same directory in guests
>
> - Run `qemu-ga.exe -s install' and `net start qemu-ga' in the guests
>
>Any feedback are appreciated.
>
>---
>Tomoki Sekiyama (10):
>      configure: Support configuring c++ compiler
>      Add c++ keywords to QAPI helper script
>      checkpatch.pl: check .cpp files
>      Add a script to extract VSS SDK headers on POSIX system
>      qemu-ga: Add configure options to specify path to Windows/VSS SDK
>      qemu-ga: Add Windows VSS provider to quiesce applications on
>fsfreeze
>      qemu-ga: Add Windows VSS requester to quiesce applications and
>filesystems
>      qemu-ga: call Windows VSS requester in fsfreeze command handler
>      qemu-ga: install Windows VSS provider on `qemu-ga -s install'
>      QMP/qemu-ga-client: make timeout longer for guest-fsfreeze-freeze
>command
>
>
> .gitignore                              |    1
> Makefile                                |    3
> Makefile.objs                           |    2
> QMP/qemu-ga-client                      |    4
> configure                               |   87 +++++
> hmp.c                                   |    2
> hw/pci/pci.c                            |    2
> qga/Makefile.objs                       |    7
> qga/commands-win32.c                    |   74 ++++-
> qga/main.c                              |   41 +++
> qga/vss-win32-provider.h                |   26 ++
> qga/vss-win32-provider/Makefile.objs    |   24 ++
> qga/vss-win32-provider/install.cpp      |  493
>+++++++++++++++++++++++++++++++
> qga/vss-win32-provider/provider.cpp     |  479
>++++++++++++++++++++++++++++++
> qga/vss-win32-provider/qga-provider.def |   10 +
> qga/vss-win32-provider/qga-provider.idl |   20 +
> qga/vss-win32-provider/qga-provider.tlb |  Bin
> qga/vss-win32-requester.cpp             |  419 ++++++++++++++++++++++++++
> qga/vss-win32-requester.h               |   31 ++
> qga/vss-win32.h                         |   86 +++++
> rules.mak                               |    9 +
> scripts/checkpatch.pl                   |   34 ++
> scripts/extract-vsssdk-headers          |   36 ++
> scripts/qapi.py                         |   12 +
> 24 files changed, 1880 insertions(+), 22 deletions(-)
> create mode 100644 qga/vss-win32-provider.h
> create mode 100644 qga/vss-win32-provider/Makefile.objs
> create mode 100644 qga/vss-win32-provider/install.cpp
> create mode 100644 qga/vss-win32-provider/provider.cpp
> create mode 100644 qga/vss-win32-provider/qga-provider.def
> create mode 100644 qga/vss-win32-provider/qga-provider.idl
> create mode 100644 qga/vss-win32-provider/qga-provider.tlb
> create mode 100644 qga/vss-win32-requester.cpp
> create mode 100644 qga/vss-win32-requester.h
> create mode 100644 qga/vss-win32.h
> create mode 100755 scripts/extract-vsssdk-headers
>