[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/3] spapr: Fix compiler warning for some versions o
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH 3/3] spapr: Fix compiler warning for some versions of gcc (spapr_io_read) |
Date: |
Mon, 24 Jun 2013 19:48:49 +0200 |
i686-w64-mingw32-gcc (GCC) 4.6.3 from Debian wheezy reports this warning:
hw/ppc/spapr_pci.c:454:1: warning:
control reaches end of non-void function [-Wreturn-type]
Adding a default case to the switch statement satisfies the compiler.
This modification requires moving the assert statement.
Signed-off-by: Stefan Weil <address@hidden>
---
hw/ppc/spapr_pci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 04e8362..c04086c 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -448,9 +448,10 @@ static uint64_t spapr_io_read(void *opaque, hwaddr addr,
case 2:
return cpu_inw(addr);
case 4:
+ default:
+ assert(size == 4);
return cpu_inl(addr);
}
- assert(0);
}
static void spapr_io_write(void *opaque, hwaddr addr,
--
1.7.10.4