[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/15] target-i386: cpu: convert 'model' to stat
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH 02/15] target-i386: cpu: convert 'model' to static property |
Date: |
Mon, 24 Jun 2013 13:53:22 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jun 05, 2013 at 03:18:33PM +0200, Igor Mammedov wrote:
> Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
> ---
> target-i386/cpu.c | 12 +++++++++---
> 1 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index c87cc9f..5d379af 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -1238,6 +1238,14 @@ static void x86_cpuid_version_set_model(Object *obj,
> Visitor *v, void *opaque,
> env->cpuid_version |= ((value & 0xf) << 4) | ((value >> 4) << 16);
> }
>
> +static PropertyInfo qdev_prop_model = {
> + .name = "uint32",
> + .get = x86_cpuid_version_get_model,
> + .set = x86_cpuid_version_set_model,
> +};
> +#define DEFINE_PROP_MODEL(_n)
> \
> + DEFINE_PROP(_n, X86CPU, env.cpuid_version, qdev_prop_model, uint32_t)
> +
> static void x86_cpuid_version_get_stepping(Object *obj, Visitor *v,
> void *opaque, const char *name,
> Error **errp)
> @@ -1485,6 +1493,7 @@ static void x86_cpu_get_feature_words(Object *obj,
> Visitor *v, void *opaque,
>
> static Property cpu_x86_properties[] = {
> DEFINE_PROP_FAMILY("family"),
> + DEFINE_PROP_MODEL("model"),
> DEFINE_PROP_END_OF_LIST(),
> };
>
> @@ -2464,9 +2473,6 @@ static void x86_cpu_initfn(Object *obj)
> cs->env_ptr = env;
> cpu_exec_init(env);
>
> - object_property_add(obj, "model", "int",
> - x86_cpuid_version_get_model,
> - x86_cpuid_version_set_model, NULL, NULL, NULL);
> object_property_add(obj, "stepping", "int",
> x86_cpuid_version_get_stepping,
> x86_cpuid_version_set_stepping, NULL, NULL, NULL);
> --
> 1.7.1
>
>
--
Eduardo
- [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1, Igor Mammedov, 2013/06/05
- [Qemu-devel] [PATCH 02/15] target-i386: cpu: convert 'model' to static property, Igor Mammedov, 2013/06/05
- Re: [Qemu-devel] [PATCH 02/15] target-i386: cpu: convert 'model' to static property,
Eduardo Habkost <=
- [Qemu-devel] [PATCH 03/15] target-i386: cpu: convert 'stepping' to static property, Igor Mammedov, 2013/06/05
- [Qemu-devel] [PATCH 04/15] target-i386: cpu: convert 'level' to static property, Igor Mammedov, 2013/06/05
- [Qemu-devel] [PATCH 05/15] target-i386: cpu: convert 'xlevel' to static property, Igor Mammedov, 2013/06/05
- [Qemu-devel] [PATCH 06/15] target-i386: cpu: convert 'vendor' to static property, Igor Mammedov, 2013/06/05
- [Qemu-devel] [PATCH 08/15] target-i386: cpu: convert 'tsc-frequency' to static property, Igor Mammedov, 2013/06/05