[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] e600 core for MPC86xx processors

From: Alexander Graf
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] e600 core for MPC86xx processors
Date: Sat, 22 Jun 2013 02:50:36 +0200

On 21.06.2013, at 01:16, Alexander Graf wrote:

> On 26.05.2013, at 19:41, Julio Guerra wrote:
>> MPC86xx processors are based on the e600 core, which is not the case
>> in qemu where it is based on the 7400 processor.
>> This patch creates the e600 core and instantiates the MPC86xx
>> processors based on it. Therefore, adding the high BATs and the SPRG
>> 4..7 registers, which are e600-specific [1].
>> This allows to define the MPC8610 processor too and my program running
>> on a real MPC8610 target is now able to run on qemu :)
>> [1] http://cache.freescale.com/files/32bit/doc/ref_manual/E600CORERM.pdf
>> Signed-off-by: Julio Guerra <address@hidden>
> Thanks, applied to ppc-next.

Sorry, I only now realized how broken this patch was. The patch hunk headers 
don't align with the length of the hunks. Spaces at the beginning of lines get 
lost towards the end. The patch as is simply treats most of the code as 
comments. Check out what patchworks does with it:


Just try to take that mbox file from there and git am it. You'll see what I 
mean. Please repost with a working mailer. Git-send-email works quite well for 
me ;).

I've removed the patch from my queue again for now.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]