Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

[Stefan Hajnoczi]

On Wed, Jun 19, 2013 at 01:19:34PM +0200, Paolo Bonzini wrote:
> Il 19/06/2013 12:50, Kevin Wolf ha scritto:
> >> > +
> >> > +    DPRINTF("%s enter %s C%" PRId64 " %" PRId64 " %d\n",
> >> > +            __func__, bdrv_get_device_name(bs), start, sector_num, 
> >> > nb_sectors);
> > Maybe put the first "%s" and __func__ directly into the DPRINTF macro?
> > 
> 
> Or just use tracepoints.  backup_do_cow could definitely be one, and it
> would subsume another DPRINTF ("backup_run loop").
> 
> hbitmap_get and block_job_completed are two other useful tracepoint that
> is not present.
> 
> All that's left then are the DPRINTF for failed readv and writev, which
> could also be useful in generic code (bdrv_co_*_done).
> 
> Can be done as a follow-up, of course.

I need to respin anyway.  The only reason for DPRINTF() is that I
originally wanted to change as little as possible from the orginal
patch.  But we've gone so far we might as well do this too :).

Stefan